[skip-ci] Packit: enable c10s downstream sync #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@inknos PTAL |
|
LGTM, I don't see any problems but also I do not know packit |
inknos
reviewed
May 9, 2024
|
LGTM |
This commit will enable downstream syncing to CentOS Stream 10. The centos maintainer will need to manually run `packit propose-downstream` and `centpkg build` until better centos integration is in place. This commit also builds both rhel and centos stream copr rpms so we can check for things like differences in python toolchain. EL8 jobs have also been deleted. CentOS Stream 8 will go EOL soon. We won't be shipping anything from main into EL8. Signed-off-by: Lokesh Mandvekar <[email protected]>
|
@inknos PTAL. Previous comment addressed. |
|
/lgtm |
|
@inknos: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will enable downstream syncing to CentOS Stream 10. The centos maintainer will need to manually run
packit propose-downstreamandcentpkg builduntil better centos integration is in place.This commit also builds both rhel and centos stream copr rpms so we can check for things like differences in python toolchain.
EL8 jobs have also been deleted. CentOS Stream 8 will go EOL soon. We won't be shipping anything from main into EL8.